-
Notifications
You must be signed in to change notification settings - Fork 33
Discovery engine #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LegendaryMercury
wants to merge
24
commits into
dev
Choose a base branch
from
discovery_engine
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Discovery engine #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Templates
First one down
New policy's done
Setup new files
Fix the last one
I need the updated files please.
So you can look for issues
Done
…ine" This reverts commit 2660c26.
Updated .helpers paths
Shani1116
requested changes
Jan 20, 2026
Contributor
Shani1116
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- chat_engine, cmek_config and search_engine folders exists in the Git branch locally, but they don’t appear in the PR.
- Service documentation is missing for your assigned service.
For more info - https://github.com/Hardhat-Enterprises/Policy-Deployment-Engine/blob/dev/scripts/docgen/README.md
policies/gcp/discovery_engine/data_connector/data_connector_data_source/policy.rego
Outdated
Show resolved
Hide resolved
policies/gcp/discovery_engine/data_connector/data_connector_location/policy.rego
Show resolved
Hide resolved
policies/gcp/discovery_engine/engine_assistant/engine_assistant_location/policy.rego
Outdated
Show resolved
Hide resolved
policies/gcp/discovery_engine/engine_control/engine_control_location/policy.rego
Outdated
Show resolved
Hide resolved
policies/gcp/discovery_engine/engine_sitemap/engine_sitemap_location/policy.rego
Outdated
Show resolved
Hide resolved
policies/gcp/discovery_engine/license_config/license_config_location/policy.rego
Outdated
Show resolved
Hide resolved
policies/gcp/discovery_engine/license_config/license_config_subscription_tier/policy.rego
Outdated
Show resolved
Hide resolved
policies/gcp/discovery_engine/license_config/license_config_subscription_tier/policy.rego
Show resolved
Hide resolved
Shani1116
approved these changes
Feb 2, 2026
Contributor
Shani1116
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved all PR comments. Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All my policies i think i can handle are done. Ready for a review!